[PATCH] D107542: [M68k][GloballSel] RegBankSelect implementation

Min-Yih Hsu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Aug 8 14:44:26 PDT 2021


myhsu added inline comments.


================
Comment at: llvm/lib/Target/M68k/GlSel/M68kRegisterBankInfo.cpp:96
+  case G_STORE: {
+    OperandsMapping = &M68k::ValueMappings[M68k::GPR3OpsIdx];
+    break;
----------------
Why line 86, 92, and 96 are the same? Can we combine them?


================
Comment at: llvm/lib/Target/M68k/GlSel/M68kRegisterBankInfo.h:44
 };
-} // end namespace llvm
+} // namespace llvm
 #endif
----------------
why change this?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107542/new/

https://reviews.llvm.org/D107542



More information about the llvm-commits mailing list