[PATCH] D107695: [llvm] [lit] Support forcing lexical test order

[Michał Górny via Phabricator via llvm-commits]

mgorny added a comment.

In D107695#2932751 <https://reviews.llvm.org/D107695#2932751>, @jdenny wrote:

> Thanks for working on this!
>
> The patch doesn't spell it consistently: sometimes `--lexical` and sometimes `--lexical-order`.

Sorry, I've forgotten how I named it :-D.

> Shouldn't we put `--lexical-order` directly into lit's test suite's `%{lit}` substitution?  That way, if another of lit's current or future tests is susceptible to this problem, no one has to waste time trying to reproduce the race and figure out what's happening.  Blindly using `%{lit}` in lit's test suite would just work.

I don't mind that. However, should we also put `-j 1` then?

> As far as I know, `reorder.py` is the only test in lit's test suite that requires the reordering.  Either it can use a `%{lit-reordered}` substitution that drops `--lexical-order`, or it can use a new command-line option that selects the default order and overrides any previous `--lexical-order` or `--shuffle`.

I suppose I could do that, and then replace the mutually exclusive group approach with 'last option wins'.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107695/new/

https://reviews.llvm.org/D107695