[PATCH] D107640: [Orc] Enable debug object tests only for 64-bit processes on x86_64 hosts

[Michał Górny via Phabricator via llvm-commits]

mgorny added inline comments.


================
Comment at: llvm/test/ExecutionEngine/OrcLazy/debug-objects-elf-minimal.ll:1-2
+# REQUIRES: x86-registered-target
+# REQUIRES: 64bit-process
+
----------------
This correctly skips the test on i386 builds for me, and runs it on amd64 builds. Also note that you need to use `;` as the comment character, as otherwise lli errors out.


================
Comment at: llvm/test/ExecutionEngine/OrcLazy/lit.local.cfg:11
+# Some tests only work for 64-bit processes on 64-bit hosts.
+if sys.int_info.sizeof_digit == 8:
+    config.available_features.add('64bit-process')
----------------
This doesn't seem to be correct. On my amd64 system, I get (with Python 3.6 through 3.10):
```
>>> import sys
>>> sys.int_info
sys.int_info(bits_per_digit=30, sizeof_digit=4)
```

Even if it worked, it wouldn't be the correct thing to do. It's common to use 64-bit Python on multilib systems where LLVM is 32-bit.

Given your earlier input, wouldn't it be sufficient to restrict the test to `x86_64`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107640/new/

https://reviews.llvm.org/D107640