[PATCH] D107554: [DWARF][Verifier] Do not add child DieRangeInfo with empty address range to the parent.

Fri Aug 6 11:55:23 PDT 2021

avl added a comment.

In D107554#2931798 <https://reviews.llvm.org/D107554#2931798>, @clayborg wrote:

> So I ran converted the yaml into an object file and ran my current llvm-dwarfdump against it:
>
>   $ llvm-dwarfdump /tmp/a.out --verify --all
>   Verifying /tmp/a.out:	file format Mach-O 64-bit x86-64
>   Verifying .debug_abbrev...
>   Verifying .debug_info Unit Header Chain...
>   Verifying .debug_info references...
>   Verifying .debug_types Unit Header Chain...
>   Verifying .debug_line...
>   No errors.

Right. This patch does not fix any error. The only effect is that performance has been improved. Is there a way to write a lit test checking  that the performance improved?
Currently the test checks that this patch does not introduce new error.

> Don't we need the "no_range1" and "no_range2" to have an address range with zero size where high and low PC values are the same?

No we do not. zero length address range is a separate case. This patch fixes a problem when dies, not having any range, affect performance.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107554/new/

https://reviews.llvm.org/D107554