[PATCH] D107627: [CMake] Check the builtins library value first

Shoaib Meenai via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 6 09:25:09 PDT 2021


smeenai added a comment.

In D107627#2930630 <https://reviews.llvm.org/D107627#2930630>, @mstorsjo wrote:

> So this is for a case where a user has explicitly specified `-DCOMPILER_RT_USE_BUILTINS_LIBRARY=YES` but it turns out to not be found? Hmm, I'm not sure if it's better to just silently ignore it like this, or clearly error out . (The previous behaviour of erroring out due to `-lNOTFOUND` not found does error out, but not in a very understandable fashion I guess.)

Agreed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107627/new/

https://reviews.llvm.org/D107627



More information about the llvm-commits mailing list