[PATCH] D107009: [WIP][X86] combineX86ShuffleChain(): canonicalize mask elts picking from splats

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon added a comment.

In D107009#2931300 <https://reviews.llvm.org/D107009#2931300>, @lebedev.ri wrote:

> TLDR: as i suspected, this is conceptually wrong, and should not have been accepted in the first place.
> The individual matchers should instead be splat-aware, much like they are already zero/undef-aware
> Indeed, there is some rudimentary support for that in e.g. `isTargetShuffleEquivalent()`/`IsElementEquivalent()`.

Didn't see this - glad we think along the same lines :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107009/new/

https://reviews.llvm.org/D107009