[PATCH] D107639: [AMDGPU][GISel] Smaller code for scalar 32 to 64-bit extensions

Fri Aug 6 08:27:45 PDT 2021

arsenm added a comment.

In D107639#2931000 <https://reviews.llvm.org/D107639#2931000>, @foad wrote:

> In D107639#2930963 <https://reviews.llvm.org/D107639#2930963>, @arsenm wrote:
>
>> I thought these got up split before selection
>
> There is code in AMDGPURegisterBankInfo::applyMappingImpl to do that for VALU, but not for SALU. Would it be better to do it there for SALU too?

Maybe this should just be a post-regbankselect combine. We don't want to have any other combines that need to create extensions to worry about this too

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107639/new/

https://reviews.llvm.org/D107639