[PATCH] D107138: [PowerPC] Implement cmplxl builtins

Victor Huang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 6 07:32:51 PDT 2021


NeHuang added inline comments.


================
Comment at: clang/test/CodeGen/builtins-ppc-xlcompat-complex.c:45
+  // CHECK-AIX-NEXT: ret { double, double } %.fca.1.insert
+  return __cmplxl(lda, ldb);
+}
----------------
nemanjai wrote:
> We really only need this test case and we should be able to just add it to one of the existing XL-compat clang test cases.
As suggest above, can we add the test case `__cmplxl` to one of the existing clang test file `builtins-ppc-xlcompat-cmplx.c`? You can auto generate the `CHECKS` using `utils/update_cc_test_checks.py` to avoid hardcoding the variable names. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107138/new/

https://reviews.llvm.org/D107138



More information about the llvm-commits mailing list