[PATCH] D107476: [ARM] Define ComplexPatternFuncMutatesDAG

Dave Green via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 6 07:00:00 PDT 2021


dmgreen added inline comments.


================
Comment at: llvm/test/CodeGen/ARM/shifter_operand.ll:520
+  %indvar.next25.3 = add i32 %indvar24, 4
+  br label %for.cond2.preheader
+
----------------
SjoerdMeijer wrote:
> You already mentioned the test case being a bit big, but do we need a loop? I guess you do, but that's unclear to me.
> 
> If it can't be reduced, can you precommit the test? Then we can see the diff here.
Unfortunately it crashes, so no changes can be shown and it can't be precommitted. I've not been able to reduce it much beyond this. The smaller example above is doing the same thing - you can see it's turning a mul into a smaller mul and a shift- but not hitting the same assert with deleted nodes.
It's not too big though, all things considered. Some of the other examples I have for other work I haven't been able to reduce past a few thousand instructions, only happening when certain register allocation patterns occur.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107476/new/

https://reviews.llvm.org/D107476



More information about the llvm-commits mailing list