[PATCH] D107597: [DAG] Fold concat_vectors(concat_vectors(x,y),concat_vectors(a,b)) -> concat_vectors(x,y,a,b)

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 6 00:39:49 PDT 2021


lebedev.ri added a comment.

Seems good to me.



================
Comment at: llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp:19899
+    for (const SDValue &Sub : Op->ops())
+      ConcatOps.push_back(Sub);
+  }
----------------
dmgreen wrote:
> Can this use ConcatOps.append?
You might actually want append_range from STLExtras here


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107597/new/

https://reviews.llvm.org/D107597



More information about the llvm-commits mailing list