[PATCH] D107324: [llvm-objcopy] [COFF] Do not patch debug entries with Repro type

Fri Aug 6 00:31:19 PDT 2021

jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

LGTM, with two inline nits.

Also super nit: in the llvm-objcopy world, it's one space after '.' :-)

================
Comment at: llvm/test/tools/llvm-objcopy/COFF/debug-entry-no-payload.test:13
+# RUN: llvm-objcopy %t.in.exe %t.out.exe
+# RUN: llvm-readobj --coff-debug-directory %t.out.exe | FileCheck %s --check-prefix=DEBUG-DIRS
+
----------------
As there are no other check prefixes used in this file, you can omit the `check-prefix` argument and just use CHECK instead of DEBUG-DIRS, if you want.

================
Comment at: llvm/test/tools/llvm-objcopy/COFF/debug-entry-no-payload.test:52-53
+    VirtualSize:     56
+    ## '10' in SectionData below indicates the Repro type for first debug
+    ## entry.  Second entry has a type of Unknown ('00').
+    SectionData:     0000000047F96B2000000000100000000000000000000000000000000000000047F96B200000000000000000000000000000000000000000
----------------

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107324/new/

https://reviews.llvm.org/D107324