[llvm] 82ca845 - [NFC] [FuncSpec] Update the Todo list for recursive functions

Chuanqi Xu via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 5 23:46:51 PDT 2021


Author: Chuanqi Xu
Date: 2021-08-06T14:43:17+08:00
New Revision: 82ca845b479359057410c14600f586fd7c86fd5b

URL: https://github.com/llvm/llvm-project/commit/82ca845b479359057410c14600f586fd7c86fd5b
DIFF: https://github.com/llvm/llvm-project/commit/82ca845b479359057410c14600f586fd7c86fd5b.diff

LOG: [NFC] [FuncSpec] Update the Todo list for recursive functions

Now the recursive functions may get specialized many times when
`func-specialization-max-iters` increases. See discussion in
https://reviews.llvm.org/D106426 for details.

Added: 
    

Modified: 
    llvm/lib/Transforms/IPO/FunctionSpecialization.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/Transforms/IPO/FunctionSpecialization.cpp b/llvm/lib/Transforms/IPO/FunctionSpecialization.cpp
index 87fe6cddda556..9ef8e3099c3e6 100644
--- a/llvm/lib/Transforms/IPO/FunctionSpecialization.cpp
+++ b/llvm/lib/Transforms/IPO/FunctionSpecialization.cpp
@@ -21,6 +21,12 @@
 //   a direct way to steer function specialization, avoiding the cost-model,
 //   and thus control compile-times / code-size.
 //
+// Todos:
+// - Limit the times a recursive function get specialized when
+// `func-specialization-max-iters`
+//   increases linearly. See discussion in https://reviews.llvm.org/D106426 for
+//   details.
+//
 //===----------------------------------------------------------------------===//
 
 #include "llvm/ADT/Statistic.h"


        


More information about the llvm-commits mailing list