[PATCH] D107620: [profile] Build with -fms-extensions in MinGW mode

[Martin Storsjö via Phabricator via llvm-commits]

mstorsjo created this revision.
mstorsjo added reviewers: phosek, aeubanks.
Herald added a subscriber: mgorny.
mstorsjo requested review of this revision.
Herald added a project: Sanitizers.
Herald added a subscriber: Sanitizers.

54902e00d1280785042e2c7ec71b25a949ade92c <https://reviews.llvm.org/rG54902e00d1280785042e2c7ec71b25a949ade92c> added a use of
/alternatename via a #pragma comment(linker); in MinGW mode, this
requires building with -fms-extensions. (This flag is added to
SANITIZER_COMMON_CFLAGS in the toplevel CMakeLists.txt.)

This avoids a warning when building in MinGW mode (about an unknown
pragma being ignored), and presumably also makes the code work as
intended.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D107620

Files:
  compiler-rt/lib/profile/CMakeLists.txt


Index: compiler-rt/lib/profile/CMakeLists.txt
===================================================================
--- compiler-rt/lib/profile/CMakeLists.txt
+++ compiler-rt/lib/profile/CMakeLists.txt
@@ -114,6 +114,9 @@
 append_list_if(COMPILER_RT_HAS_NOSTDINCXX_FLAG -nostdinc++ EXTRA_FLAGS)
 # XRay uses C++ standard library headers.
 string(REGEX REPLACE "-stdlib=[a-zA-Z+]*" "" CMAKE_CXX_FLAGS ${CMAKE_CXX_FLAGS})
+# The Windows specific code uses a #pragma comment(linker, ...) which requires
+# -fms-extensions on MinGW targets.
+append_list_if(MINGW -fms-extensions EXTRA_FLAGS)
 
 # This appears to be a C-only warning banning the use of locals in aggregate
 # initializers. All other compilers accept this, though.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D107620.364701.patch
Type: text/x-patch
Size: 724 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210806/3a1222df/attachment.bin>