[PATCH] D107618: [LoopCacheAnalysis]: handle mismatch type for Numerator and CacheLineSize

[ChenZheng via Phabricator via llvm-commits]

shchenz created this revision.
shchenz added reviewers: jsji, jdoerfert, bmahjour, Whitney, PowerPC.
Herald added subscribers: hiraditya, nemanjai.
shchenz requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

fix an assertion due to mismatch type for Numerator and CacheLineSize in loop cache analysis pass.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D107618

Files:
  llvm/lib/Analysis/LoopCacheAnalysis.cpp
  llvm/test/Analysis/LoopCacheAnalysis/PowerPC/compute-cost-m32.ll


Index: llvm/test/Analysis/LoopCacheAnalysis/PowerPC/compute-cost-m32.ll
===================================================================
--- /dev/null
+++ llvm/test/Analysis/LoopCacheAnalysis/PowerPC/compute-cost-m32.ll
@@ -0,0 +1,28 @@
+; RUN: opt < %s -passes='print<loop-cache-cost>' -disable-output 2>&1 | FileCheck %s
+
+target datalayout = "E-m:a-i64:64-p:32:32-n32-S128-v256:256:256-v512:512:512"
+target triple = "powerpc-ibm-aix7.2.0.0"
+
+; Check IndexedReference::computeRefCost can handle type differences between
+; CacheLineSize and Numerator
+
+; CHECK: Loop '_loop_1_do_' has cost = 2
+
+%_elem_type_of_v = type <{ i32 }>
+
+define signext i32 @foo(%_elem_type_of_v* %v) {
+_entry:
+  br label %_loop_1_do_
+
+_loop_1_do_:                                      ; preds = %_entry, %_loop_1_do_
+  %i.011 = phi i64 [ 1, %_entry ], [ %_loop_1_update_loop_ix, %_loop_1_do_ ]
+  %_conv = trunc i64 %i.011 to i32
+  %_ind_cast = getelementptr %_elem_type_of_v, %_elem_type_of_v* %v, i32 %_conv, i32 0
+  store i32 %_conv, i32* %_ind_cast, align 4
+  %_loop_1_update_loop_ix = add nuw nsw i64 %i.011, 1
+  %_leq_tmp = icmp ult i64 %_loop_1_update_loop_ix, 33
+  br i1 %_leq_tmp, label %_loop_1_do_, label %_loop_1_endl_
+
+_loop_1_endl_:                                    ; preds = %_loop_1_do_
+  ret i32 0
+}
Index: llvm/lib/Analysis/LoopCacheAnalysis.cpp
===================================================================
--- llvm/lib/Analysis/LoopCacheAnalysis.cpp
+++ llvm/lib/Analysis/LoopCacheAnalysis.cpp
@@ -290,8 +290,8 @@
     const SCEV *Coeff = getLastCoefficient();
     const SCEV *ElemSize = Sizes.back();
     const SCEV *Stride = SE.getMulExpr(Coeff, ElemSize);
-    const SCEV *CacheLineSize = SE.getConstant(Stride->getType(), CLS);
     Type *WiderType = SE.getWiderType(Stride->getType(), TripCount->getType());
+    const SCEV *CacheLineSize = SE.getConstant(WiderType, CLS);
     if (SE.isKnownNegative(Stride))
       Stride = SE.getNegativeSCEV(Stride);
     Stride = SE.getNoopOrAnyExtend(Stride, WiderType);


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D107618.364696.patch
Type: text/x-patch
Size: 2049 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210806/30dba025/attachment.bin>