[PATCH] D107581: [LegalizeTypes] Add a simple expansion for SMULO when a libcall isn't available.

[Pengfei Wang via Phabricator via llvm-commits]

pengfei added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/LegalizeIntegerTypes.cpp:4053
+        DAG.getSetCC(dl, N->getValueType(1), MulHi, SRA, ISD::SETNE);
+    SplitInteger(MulLo, Lo, Hi);
+    ReplaceValueWith(SDValue(N, 1), Overflow);
----------------
craig.topper wrote:
> pengfei wrote:
> > Seems `Lo` and `Hi` are not used?
> They are output references passed to this function see line 3969.
Oh, I saw them in the function arguments. Sorry for the noise.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107581/new/

https://reviews.llvm.org/D107581