[PATCH] D107277: GlobalISel: Add helper function for getting EVT from LLT

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 5 16:02:34 PDT 2021


arsenm added inline comments.


================
Comment at: llvm/lib/CodeGen/TargetLoweringBase.cpp:1753
+  EVT VT = getApproximateEVTForLLT(Ty, DL, Context);
+  return allowsMemoryAccess(Context, DL, VT, MMO.getAddrSpace(), MMO.getAlign(),
+                            MMO.getFlags(), Fast);
----------------
paquette wrote:
> Since this is an approximation, could this return the wrong answer?
Depends what you mean by "wrong". Mostly this just loses FP types and pointers and returns an int type


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107277/new/

https://reviews.llvm.org/D107277



More information about the llvm-commits mailing list