[PATCH] D107574: [GlobalOpt] [MemoryBuiltins] Update getMallocType with bitcast on stored pointer

[Eli Friedman via Phabricator via llvm-commits]

efriedma added a comment.

In D107574#2929796 <https://reviews.llvm.org/D107574#2929796>, @scui wrote:

> It looks to me the IR code will be sub-optimal for some cases if we simply return Type i8* for getMallocType.

Will it?  Almost all optimizations can deal with bitcasts of global variables without getting confused.

Anyway, if you want to refine the type of the global created by the transform, I guess that's okay, but confusion about the types involved shouldn't ever block the transform.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107574/new/

https://reviews.llvm.org/D107574