[PATCH] D107162: [lit] Have REQUIRES support the target triple

[Paul Robinson via Phabricator via llvm-commits]

probinson added a comment.

The two tests that went from Unsupported to Pass are

  LLVM :: tools/llvm-readobj/COFF/call-graph-profile-err.s
  LLVM :: tools/llvm-readobj/COFF/call-graph-profile.s

both of which have `REQUIRES: x86` which matches the default triple on my system (x86_64-unknown-linux) but isn't the right way to constrain the test in a pre-patch world; that would be `target-x86` or `target-x86_64` or both.

Reviewers have expressed some need for caution in applying this patch, and there might well be tests out there that mistakenly have things like `REQUIRES: arm` or `REQUIRES: powerpc` and don't happily pass once they are suddenly enabled for the first time.  So, I guess that means I won't be pushing this upstream at quitting time on Friday after all. :-)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107162/new/

https://reviews.llvm.org/D107162