[PATCH] D100102: [VPlan] Iterate over phi recipes to detect reductions to fix.

[Ayal Zaks via Phabricator via llvm-commits]

Ayal accepted this revision.
Ayal added a comment.
This revision is now accepted and ready to land.

Thanks! This looks good to me, with a minor comment comment.



================
Comment at: llvm/lib/Transforms/Vectorize/LoopVectorize.cpp:9582
+  //  Note that this is currently only used to reflect the def-use chains in
+  //  VPlan. fixReduction will introduce the appropriate selects and update the
+  //  users outside the loop without relying on the select recipe.
----------------
Update comment? As noted below, fixReduction does rely on the select generated by this recipe, rather than introduce another one.

nit: extra space at the beginning of each line?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100102/new/

https://reviews.llvm.org/D100102