[PATCH] D107594: [NFC][MLGO] Make logging more robust
Mircea Trofin via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Aug 5 12:31:32 PDT 2021
mtrofin created this revision.
mtrofin added reviewers: jacobhegna, yundiqian.
Herald added subscribers: ChuanqiXu, hiraditya.
mtrofin requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
1. add some self-diagnosis (when asserts are enabled) to check that all
features have the same nr of entries
2. avoid storing pointers to mutable fields because the proto API
contract doesn't actually guarantee those stay fixed even if no further
mutation of the object occurs.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D107594
Files:
llvm/include/llvm/Analysis/Utils/TFUtils.h
llvm/lib/Analysis/DevelopmentModeInlineAdvisor.cpp
llvm/lib/Analysis/TFUtils.cpp
llvm/unittests/Analysis/TFUtilsTest.cpp
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D107594.364580.patch
Type: text/x-patch
Size: 7692 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210805/067ad3cd/attachment.bin>
More information about the llvm-commits
mailing list