[PATCH] D107162: [lit] Have REQUIRES support the target triple
Joel E. Denny via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Aug 5 11:53:54 PDT 2021
jdenny accepted this revision.
jdenny added a comment.
Reviewing comments from @yln and @delcypher, it seems we're all mostly in agreement now, and I haven't found a good reason to object.
LGTM with a few remaining caveats:
1. It needs the documentation we discussed.
2. I'd like to give @ldionne a few more days to comment given that he's already been thinking about the handling of target triples.
3. We might have to revert the patch if it undesirably enables tests in test suites that haven't been tried yet.
Thanks for working on this, @probinson.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D107162/new/
https://reviews.llvm.org/D107162
More information about the llvm-commits
mailing list