[PATCH] D107527: Mark getc_unlocked as unavailable by default

[Fangrui Song via Phabricator via llvm-commits]

MaskRay accepted this revision.
MaskRay added inline comments.


================
Comment at: llvm/test/Transforms/InferFunctionAttrs/annotate.ll:514
+; CHECK-UNKNOWN: declare i32 @getc_unlocked(%opaque*)
+; CHECK-UNKNOWN-NOT: #{{.*}}
 declare i32 @getc_unlocked(%opaque*)
----------------
What does this check?

Many times it'd be better to replace negative checks with positive checks, with a comment stating that we don't want to see certain things.

Negative checks can quite easily become stale. For example, if another function is inserted below and it has a `#`, the test will fail weirdly.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107527/new/

https://reviews.llvm.org/D107527