[PATCH] D107575: Ported test_errors.sh to Python

Michael Kruse via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 5 10:12:54 PDT 2021


Meinersbur added a comment.

There seems to be a problem in how `import common` not finding `common.py` in a sibling directory.

`vsnprintf` is named `_vsnprintf` by Microsoft. According to their docs <https://docs.microsoft.com/en-us/previous-versions/visualstudio/visual-studio-2013/1kt27hek(v=vs.120)>, it should also be available as `vsnprintf` with

  #include <stdio.h>
  #include <stdarg.h>

but even Google test <https://github.com/google/googletest/blob/5b40153003d1a5ad7b8f40cffcd09434afda3428/googletest/src/gtest.cc#L121> uses

  #if GTEST_OS_WINDOWS
  # define vsnprintf _vsnprintf
  #endif  // GTEST_OS_WINDOWS


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107575/new/

https://reviews.llvm.org/D107575



More information about the llvm-commits mailing list