[PATCH] D107572: [DAG] DAGCombiner::visitVECTOR_SHUFFLE - recognise chain of INSERT_SUBVECTOR patterns

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 5 09:58:01 PDT 2021


lebedev.ri updated this revision to Diff 364523.
lebedev.ri added a comment.

In D107572#2928704 <https://reviews.llvm.org/D107572#2928704>, @RKSimon wrote:

> I'm working on a concat(concat,concat) fold that should help a lot more than this (although I might not get it finished before going on holiday next week) - what could be done as an extension of D107068 <https://reviews.llvm.org/D107068> is handle the case where the insert_subvector straddles multiple concat entries (i.e. slice the concat ops into a smaller concat and insert that as a subvector).

Hmm yeah, now that i have fixed the code to actually work as planned, it currently does not trigger on any of the existing tests.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107572/new/

https://reviews.llvm.org/D107572

Files:
  llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D107572.364523.patch
Type: text/x-patch
Size: 5270 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210805/b8e44b0f/attachment.bin>


More information about the llvm-commits mailing list