[PATCH] D107240: [LLVM][NFC] Make multiple bitwise MathExtras functions constexpr

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: llvm/include/llvm/Support/MathExtras.h:116
 
-#if defined(__GNUC__) || defined(_MSC_VER)
+#if defined(_MSC_VER) || __has_builtin(__builtin_ctz) || defined(__GNUC__)
+
----------------
Doesn't this mean that users of this that want to use it in constexpr can't compile that code with MSVC and would need a different solution just for MSVC? Is that useful for the project?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107240/new/

https://reviews.llvm.org/D107240