[PATCH] D107427: [PATCH] [llvm] [lit] Fix inconsistent test order in shtest-keyword-parse-errors

Joel E. Denny via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 5 09:06:37 PDT 2021


jdenny added a comment.

In D107427#2928786 <https://reviews.llvm.org/D107427#2928786>, @mgorny wrote:

> You're welcome. I'd love to try to figure out how to make the tests not depend on subtest order but my TODO is too long already.

Yes, it's not my highest priority either.

I think some sort of command-line option to disable this behavior is the right solution, and it can be embedded in `%{lit}` so that no test is affected accidentally.  (I'd like to use that in `clang/test/utils` as well.)  For tests that specifically check this behavior (`reorder.py`), an alternate substitution (e.g., `%{lit-reordered}`) can be provided.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107427/new/

https://reviews.llvm.org/D107427



More information about the llvm-commits mailing list