[PATCH] D107542: [M68k][GloballSel] RegBankSelect implementation

[Anshil Gandhi via Phabricator via llvm-commits]

gandhi21299 added inline comments.


================
Comment at: llvm/lib/Target/M68k/GlSel/M68kRegisterBankInfo.cpp:80
+  const MachineFunction &MF = *MI.getParent()->getParent();
+  const MachineRegisterInfo &MRI = MF.getRegInfo();
+  unsigned NumOperands = MI.getNumOperands();
----------------
I don't see MRI used anywhere


================
Comment at: llvm/lib/Target/M68k/GlSel/M68kRegisterBankInfo.h:46
+#endif
\ No newline at end of file

----------------
please add a newline here


================
Comment at: llvm/test/CodeGen/M68k/GlobalISel/reg_bank_test.ll:4
+define i32 @test_add(i32 %x, i32 %y) {
+  ; CHECK-LABEL: name: test_add
+  %sum = add i32 %x, %y
----------------
please add more CHECKS for MIR


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107542/new/

https://reviews.llvm.org/D107542