[PATCH] D107353: [LoopIdiom] let the pass deal with runtime memset size

[Yueh-Ting Chen via Phabricator via llvm-commits]

eopXD added inline comments.


================
Comment at: llvm/lib/Transforms/Scalar/LoopIdiomRecognize.cpp:917
 
-  // Check to see if the stride matches the size of the memset.  If so, then we
-  // know that every byte is touched in the loop.
-  const SCEVConstant *ConstStride = dyn_cast<SCEVConstant>(Ev->getOperand(1));
-  if (!ConstStride)
-    return false;
+  bool NegStride;
+  const bool IsConstantSize = isa<ConstantInt>(MSI->getLength());
----------------
lebedev.ri wrote:
> Can you make this change globally trouough the file in a preparatory NFC patch?
> 
> (Though, somehow it feels conceptually wrong to pass it into processLoopStridedStore().)
NFC patch: D107570.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107353/new/

https://reviews.llvm.org/D107353