[PATCH] D107567: [AArch64] provide strictfp attributes in test file

[Simon Wallis via Phabricator via llvm-commits]

simonwallis2 created this revision.
simonwallis2 added a reviewer: kpn.
Herald added subscribers: danielkiss, kristof.beyls.
simonwallis2 requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

A post-commit review comment on  https://reviews.llvm.org/D107452 pointed out that 
https://llvm.org/docs/LangRef.html 
says: 
"In a function that uses the constrained intrinsics the strictfp attribute is required on all function calls."

Although there are several files across several test directories which don't follow this guidance, it is straightforward to provide this attribute.


https://reviews.llvm.org/D107567

Files:
  llvm/test/CodeGen/AArch64/fptosi-strictfp.ll


Index: llvm/test/CodeGen/AArch64/fptosi-strictfp.ll
===================================================================
--- llvm/test/CodeGen/AArch64/fptosi-strictfp.ll
+++ llvm/test/CodeGen/AArch64/fptosi-strictfp.ll
@@ -2,22 +2,24 @@
 target datalayout = "e-m:e-i8:8:32-i16:16:32-i64:64-i128:128-n32:64-S128"
 target triple = "aarch64-arm-none-eabi"
 
-define i128 @test_fixtfti(fp128 %ld) {
+define i128 @test_fixtfti(fp128 %ld) #0 {
 ; CHECK-LABEL: test_fixtfti:
 ; CHECK: bl	__fixtfti
 entry:
-  %conv = call i128 @llvm.experimental.constrained.fptosi.i128.f128(fp128 %ld, metadata !"fpexcept.strict")
+  %conv = call i128 @llvm.experimental.constrained.fptosi.i128.f128(fp128 %ld, metadata !"fpexcept.strict") #0
   ret i128 %conv
 }
 
 declare i128 @llvm.experimental.constrained.fptosi.i128.f128(fp128, metadata)
 
-define i128 @test_fixtftu(fp128 %ld) {
+define i128 @test_fixtftu(fp128 %ld) #0 {
 ; CHECK-LABEL: test_fixtftu:
 ; CHECK: bl	__fixunstfti
 entry:
-  %conv = call i128 @llvm.experimental.constrained.fptoui.i128.f128(fp128 %ld, metadata !"fpexcept.strict")
+  %conv = call i128 @llvm.experimental.constrained.fptoui.i128.f128(fp128 %ld, metadata !"fpexcept.strict") #0
   ret i128 %conv
 }
 
 declare i128 @llvm.experimental.constrained.fptoui.i128.f128(fp128, metadata)
+
+attributes #0 = { strictfp }


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D107567.364442.patch
Type: text/x-patch
Size: 1325 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210805/100e61b6/attachment.bin>