[PATCH] D107551: [DAGCombine] Add node level checks for fp-contract and fp-ninf in visitFMULForFMADistributiveCombine().

Abinav Puthan Purayil via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 5 04:41:19 PDT 2021


abinavpp added a comment.

In D107551#2928034 <https://reviews.llvm.org/D107551#2928034>, @RKSimon wrote:

> This patch has no description summary at all :( What's the background to this? Is it related to PR51346 / D74436 <https://reviews.llvm.org/D74436>?

I'm sorry about that.  I believe @arsenm would know the background to this. If I understood the issue raised by @arsenm correctly, we need DAG-combine APIs to not just check for fp-model specific flags, but to have finer SDNode level checks. The only example as a motivation for this is what I added in AMDGPU/fma.ll.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107551/new/

https://reviews.llvm.org/D107551



More information about the llvm-commits mailing list