[PATCH] D107324: [llvm-objcopy] [COFF] Do not patch debug entries with Repro type

Thu Aug 5 00:24:57 PDT 2021

jhenderson added inline comments.

================
Comment at: llvm/test/tools/llvm-objcopy/COFF/debug-entry-no-payload.test:2
+## Check that debug directory entries without a payload (e.g.
+## IMAGE_DEBUG_TYPE_REPRO, IMAGE_DEBUG_TYPE_UNKNOWN) are handled correctly
+## when llvm-objcopy patches entries that may have moved during a requested
----------------
"are handled correctly" usually implies that something needs to be checked, in my mind, namely that the debug directory entries look correct after the invocation of llvm-objcopy. It's this that should be checked. If on the other hand, you think it should be just checking for lack of an error, it's probably best to say just that. I'd check the debug entry though.

================
Comment at: llvm/test/tools/llvm-objcopy/COFF/debug-entry-no-payload.test:47
+    VirtualSize:     56
+    ## '10' in SectionData below indicates the Repro debug entry type.
+    SectionData:     0000000047F96B2000000000100000000000000000000000000000000000000047F96B200000000000000000000000000000000000000000
----------------
If I'm not mistaken, there are two entries here below. If so, please update this comment.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107324/new/

https://reviews.llvm.org/D107324