[PATCH] D107513: [MemCpyOpt/MemorySSA] Do not run the pass for prohibitively large number of memory accesses.
Arthur Eubanks via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Aug 4 22:49:49 PDT 2021
aeubanks added a comment.
For some context, we're seeing this in __llvm_gcov_reset, a function generated by the gcov pass. One module contains a __llvm_gcov_reset containing 100000+ stores, many of which are changed to memsets by MemCpyOpt.
I'm sort of on the fence for this change since this change is not super principled. The IR created by the gcov pass is somewhat unreasonable and IMO a super edge case. D107538 <https://reviews.llvm.org/D107538> fixes GCov.
Any other thoughts? Should we support extreme IR edge cases?
Needs a test though
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D107513/new/
https://reviews.llvm.org/D107513
More information about the llvm-commits
mailing list