[PATCH] D107527: Mark getc_unlocked as unavailable by default

Ryan Prichard via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 4 20:36:30 PDT 2021


rprichard added reviewers: xbolva00, MaskRay, efriedma, echristo.
rprichard added a comment.

I noticed this inconsistency while reviewing D107509 <https://reviews.llvm.org/D107509>.

For the MSVC environment, Clang currently annotates `getc_unlocked` with `nocapture`, which could technically be wrong if `getc_unlocked` were an unrelated function. MSVC's CRT doesn't define `*_unlocked` functions. https://godbolt.org/z/GreGM6x8G.

(MSVC does define `*_nolock` functions, which look similar, but I haven't looked closely.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107527/new/

https://reviews.llvm.org/D107527



More information about the llvm-commits mailing list