[PATCH] D107322: [llvm-ar] Fix for handling thin archive with SYM64 and a test case for it

[Ramesh Peri via Phabricator via llvm-commits]

Ramesh marked an inline comment as done.
Ramesh added inline comments.


================
Comment at: llvm/test/Object/archive-symtab.test:55
+# RUN: env SYM64_THRESHOLD=0 llvm-ar crTs %t.a %t.elf-x86-64 %t2.elf-x86-64
+# RUN: llvm-nm -M  %t.a | FileCheck %s
+# RUN: grep '/SYM64/' %t.a
----------------
MaskRay wrote:
> -M => --print-armap
> 
> -M was inappropriately added when -s was taken by Darwin nm. -M will be removed and should not be used.
There are a number of other tests which are using this option still - what needs to be done about them?


================
Comment at: llvm/test/Object/archive-symtab.test:68
 
+
 # CHECK: Archive map
----------------
MaskRay wrote:
> drop unrelated change
Will fix it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107322/new/

https://reviews.llvm.org/D107322