[PATCH] D106448: [WIP] [llvm][Inline] Add module level inliner

Kazu Hirata via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 4 16:45:54 PDT 2021


kazu added a comment.

This patch looks good to me in general.  The huge amount of duplicate code is a concern, but I am not too worried as long as it's all contained in ModuleInliner.cpp.

I'd like to see the clang-tidy messages addressed before you check this in.  By the way, I think you can safely ignore the one about erase_if.



================
Comment at: llvm/include/llvm/Transforms/IPO/Inliner.h:20
 #include "llvm/IR/PassManager.h"
+#include "llvm/Transforms/IPO/ModuleInliner.h"
 #include <utility>
----------------
I think you can remove this line.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106448/new/

https://reviews.llvm.org/D106448



More information about the llvm-commits mailing list