[PATCH] D107509: Disable LibFuncs for stpcpy and stpncpy for Android < 21
Shoaib Meenai via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Aug 4 16:07:09 PDT 2021
smeenai added reviewers: danalbert, rprichard, srhines, eugenis.
smeenai added a comment.
Might be helpful to mention rG6dbf0cfcf789 <https://reviews.llvm.org/rG6dbf0cfcf789365493f70ae69df8a7a59be41c75> in the commit message.
Is there any way to add a test to this (especially for the triple version conditional), similar to what rGc5638a71d805 <https://reviews.llvm.org/rGc5638a71d805330294e9b6e2c670e1ed7420b63a> did? I imagine it might be complicated because I think our original test case triggered two transforms (sprintf -> strcpy and then strcpy -> stpcpy), but hopefully there's some test for the stpcpy transform that we can piggy-back off.
Adding a bunch of Android folks as reviewers.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D107509/new/
https://reviews.llvm.org/D107509
More information about the llvm-commits
mailing list