[PATCH] D107162: [lit] Have REQUIRES support the target triple

[Joel E. Denny via Phabricator via llvm-commits]

jdenny added a comment.

In D107162#2926821 <https://reviews.llvm.org/D107162#2926821>, @probinson wrote:

> Correct.

Thanks for confirming.

> I'll note that there are a bunch of triple-based (and sometimes triple-like) feature keywords added by lit, based on the target triple (see the block starting `if target_triple:` at circa line 106 in llvm/utils/lit/lit/llvm/config.py),

Ah, thanks.

> which of course could be replaced by regexes in UNSUPPORTED/XFAIL already, and also in REQUIRES if this patch goes in.

Maybe I missed a patch since D104572 <https://reviews.llvm.org/D104572>, but it did **not** add support for regexes matching the target triple.  It added support for regexes matching features, as described in the documentation I pointed out.  Now that I think about it more, I'm not sure I know what @ldionne ultimately wanted to see happen with target triples.  It might be good to hear him comment before moving forward.

> I can try doing "all" projects and see what happens, although my track record on getting clean builds and tests is imperfect.

Same here.  Sometimes we just have to let the bots find things, unfortunately.

>> - Hiding test failures accidentally is bad.  Exposing test failures accidentally is not so bad.
>> - From that perspective, it seems exactly backward that UNSUPPORTED and XFAIL currently match more broadly than REQUIRES.  Why was that decision made?
>
> "It was like that when I found it."

:-)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107162/new/

https://reviews.llvm.org/D107162