[PATCH] D107505: [AArch64][GlobalISel] Overhaul G_EXTRACT legalization

Jessica Paquette via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 4 15:05:35 PDT 2021


paquette created this revision.
paquette added reviewers: aemerson, jroelofs.
Herald added subscribers: danielkiss, hiraditya, kristof.beyls, rovka.
paquette requested review of this revision.
Herald added a project: LLVM.

This simplifies our existing G_EXTRACT rules and adds some test coverage. Mostly changing this because it should make it easier to improve legalization for instructions which use G_EXTRACT as part of the legalization process.

This also adds support for legalizing some weird types. Similar to other recent legalizer changes, this changes the order of widening/clamping.

There was some dead code in our existing rules (e.g. the p0 case would never get hit), so this knocks those out and makes the types we want to handle explicit.

This also removes some checks which, nowadays, are handled by the MachineVerifier.


https://reviews.llvm.org/D107505

Files:
  llvm/lib/Target/AArch64/GISel/AArch64LegalizerInfo.cpp
  llvm/test/CodeGen/AArch64/GlobalISel/legalize-combines.mir
  llvm/test/CodeGen/AArch64/GlobalISel/legalize-extracts.mir
  llvm/test/CodeGen/AArch64/GlobalISel/legalize-inserts.mir

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D107505.364259.patch
Type: text/x-patch
Size: 93260 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210804/93893204/attachment-0001.bin>


More information about the llvm-commits mailing list