[PATCH] D105207: [debuginfo][lsr] SCEV-based salvaging for LoopStrengthReduction

Wed Aug 4 14:43:11 PDT 2021

chrisjackson added a comment.

In D105207#2926535 <https://reviews.llvm.org/D105207#2926535>, @JosephTremoulet wrote:

> In D105207#2924918 <https://reviews.llvm.org/D105207#2924918>, @chrisjackson wrote:
>
>> Apologies for thre slow response, I currently have covid so I needed some time off. Thanks for reporting the failure I will attempt to address the assertion failure today. If I fix that then I am keen for this to be backported.
>>
>> In D105207#2922863 <https://reviews.llvm.org/D105207#2922863>, @JosephTremoulet wrote:
>>
>>> We've got a regression (assertion failure) with this change that didn't get fixed with 2537120c870c <https://reviews.llvm.org/rG2537120c870c04893636f171f553024f378c2de8>.  I've opened PR 51329 <https://bugs.llvm.org/show_bug.cgi?id=51329> for it.  If this change gets backported to release/13.x, we'll need the fix for this assertion failure to also get backported.
>>
>> Please see D107348 <https://reviews.llvm.org/D107438> for a simple patch that provides a fix.
>
> Thanks for the quick turnaround.  I've verified that 21ee38e24f98 <https://reviews.llvm.org/rG21ee38e24f9801a567306b2a88defacf6e589a8b> fixes the original issues in our rolling tests as well as the reduced repro.  I'm happy for this change to get backported along with 21ee38e24f98 <https://reviews.llvm.org/rG21ee38e24f9801a567306b2a88defacf6e589a8b>.

My pleasure. Thanks for verifying. Just to confirm, I will backport the required three patches to the 13.x release branch:

rG0ba8595287ea2203ef2250e2b0b41f284a055518 <https://reviews.llvm.org/rG0ba8595287ea2203ef2250e2b0b41f284a055518>
 rG2537120c8 <https://reviews.llvm.org/rG2537120c870c04893636f171f553024f378c2de8>
 rG21ee38e24f9801a567306b2a88defacf6e589a8b <https://reviews.llvm.org/rG21ee38e24f9801a567306b2a88defacf6e589a8b>

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105207/new/

https://reviews.llvm.org/D105207