[PATCH] D107416: [lld] Remove unused LLD_REPOSITORY

Wed Aug 4 14:04:57 PDT 2021

MaskRay added a comment.

In D107416#2926638 <https://reviews.llvm.org/D107416#2926638>, @GMNGeoffrey wrote:

> These variables still appear to be defined by https://github.com/llvm/llvm-project/blob/9c19b36f1c/lld/Common/CMakeLists.txt#L10-L11. Should they be removed there as well?
>
>   set(version_inc "${CMAKE_CURRENT_BINARY_DIR}/VCSVersion.inc")
>   set(generate_vcs_version_script "${LLVM_CMAKE_PATH}/GenerateVersionFromVCS.cmake")

Looks like I probably should bring back the code.

The code ensures that we can get this `ld.lld --version` output when `-DLLVM_APPEND_VC_REV=ON`:

`LLD 14.0.0 (git at github.com:llvm/llvm-project.git a1944386156dbbfae15dfc606a3728e08ac92cfe) (compatible with GNU linkers)`

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107416/new/

https://reviews.llvm.org/D107416