[PATCH] D107427: [PATCH] [llvm] [lit] Fix inconsistent test order in shtest-keyword-parse-errors

Joel E. Denny via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 4 13:24:02 PDT 2021


jdenny accepted this revision.
jdenny added a subscriber: lebedev.ri.
jdenny added a comment.
This revision is now accepted and ready to land.

Other than a tiny nit, LGTM.



================
Comment at: llvm/utils/lit/tests/shtest-keyword-parse-errors.py:1
+# RUN: rm -f %{inputs}/shtest-keyword-parse-errors/.lit_test_times.txt
 # RUN: not %{lit} -j 1 -vv %{inputs}/shtest-keyword-parse-errors > %t.out
----------------
@lebedev.ri has been marking these lines with a FIXME: ef4b3a4571e2.

Perhaps it's good to do that consistently until someone implements a more comprehensive fix (like putting the cleanup or some command-line option in `%{lit}`).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107427/new/

https://reviews.llvm.org/D107427



More information about the llvm-commits mailing list