[PATCH] D107162: [lit] Have REQUIRES support the target triple

Wed Aug 4 13:23:19 PDT 2021

yln added a comment.

In D107162#2926617 <https://reviews.llvm.org/D107162#2926617>, @jdenny wrote:

> - Hiding test failures accidentally is bad. Exposing test failures accidentally is not so bad.
> - From that perspective, it seems exactly backward that UNSUPPORTED and XFAIL currently match more broadly than REQUIRES.
> - I do agree that eventually it would be nice to get rid of substring matching in favor of regexes for XFAIL and UNSUPPORTED, where matching more broadly than intended is dangerous.

I completely agree with these points made by Joel.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107162/new/

https://reviews.llvm.org/D107162