[PATCH] D107452: [AArch64] Fix assert AArch64TargetLowering::ReplaceNodeResults

[Kevin P. Neal via Phabricator via llvm-commits]

kpn added inline comments.


================
Comment at: llvm/test/CodeGen/AArch64/fptosi-strictfp.ll:23-24
+
+attributes #0 = { strictfp }
+attributes #1 = { inaccessiblememonly mustprogress nofree nosync nounwind willreturn }
----------------
dmgreen wrote:
> Can probably remove these.
Removing the attributes is incorrect.

All functions that use the strictfp intrinsics require the strictfp attribute on the function definition.

In a function that uses the constrained intrinsics the strictfp attribute is required on all function calls.

This is in the Language Ref. It is not yet in the verifier because last time I tried it we had clang test failures.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107452/new/

https://reviews.llvm.org/D107452