[PATCH] D107133: [AVR] emit `MCSA_Global` references to `__do_global_ctors` and `__do_global_dtors`

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: llvm/lib/Target/AVR/AVRAsmPrinter.cpp:226
+
+  OutStreamer->emitRawComment(" Declaring this symbol tells the CRT that it should");
+  OutStreamer->emitRawComment("copy all variables from program memory to RAM on startup");
----------------
mhjacobson wrote:
> MaskRay wrote:
> > Leading space is not needed
> The leading space seems to be pretty common for calls to `emitRawComment`, not just in the AVR target but others too.  It turns
> 
> ```
> ;Declaring this symbol
> ```
> 
> into
> 
> ```
> ; Declaring this symbol
> ```
> 
> which looks prettier for anyone having to look at the generated assembly.
> 
> (I'll fix the linter complaint.)
ok, i thought `emitRawComment` ensured a space when `#` is used. Perhaps that's not the case, or not the case for `;`


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107133/new/

https://reviews.llvm.org/D107133