[PATCH] D104595: [NFC] [LoopIdiom] Let processLoopStridedStore take StoreSize as SCEV instead of unsigned

[Whitney Tsang via Phabricator via llvm-commits]

Whitney added inline comments.


================
Comment at: llvm/lib/Transforms/Scalar/LoopIdiomRecognize.cpp:916
 
+  const SCEV *MemsetSizeSCEV = SE->getSCEV(MSI->getLength());
+  if (!MemsetSizeSCEV)
----------------
Is it better to have line 916-918 after 921-923?

In what case, `!MemsetSizeSCEV`? Do we early exit more often than before?


================
Comment at: llvm/lib/Transforms/Scalar/LoopIdiomRecognize.cpp:986
 
+// forwards StoreSize as SCEV, aim to replace usage of this prototype to
+// let LIR deal with runtime-determined store size.
----------------
comments start with uppercase.


================
Comment at: llvm/lib/Transforms/Scalar/LoopIdiomRecognize.cpp:1151
 
-  const SCEV *NumBytesS =
-      getNumBytes(BECount, IntIdxTy, StoreSize, CurLoop, DL, SE);
+  // NumBytes = TripCount * StoreSize
+  const SCEV *TripCountS = getTripCount(BECount, IntIdxTy, CurLoop, DL, SE);
----------------
Is this really NFC?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104595/new/

https://reviews.llvm.org/D104595