[PATCH] D107480: [Bazel] Update build for ee7d20e846

Geoffrey Martin-Noble via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 4 10:05:07 PDT 2021


GMNGeoffrey created this revision.
GMNGeoffrey requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

Updates the Bazel configuration for
https://github.com/llvm/llvm-project/commit/ee7d20e84675. We need to
drop the dependency from llvm-tblgen to avoid a dependency cycle:

  .-> @llvm-project//llvm:llvm-tblgen
  |   @llvm-project//llvm:tblgen
  |   @llvm-project//llvm:MC
  |   @llvm-project//llvm:ProfileData
  |   @llvm-project//llvm:Core
  |   @llvm-project//llvm:attributes_gen
  |   @llvm-project//llvm:include/llvm/IR/Attributes.inc
  |   @llvm-project//llvm:attributes_gen__gen_attrs_genrule
  `-- @llvm-project//llvm:llvm-tblgen

It appears this dep was not strictly necessary though. TableGen uses MC
headers but it can get those through Support, which also exports MC
headers due to layering issues.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D107480

Files:
  utils/bazel/llvm-project-overlay/llvm/BUILD.bazel


Index: utils/bazel/llvm-project-overlay/llvm/BUILD.bazel
===================================================================
--- utils/bazel/llvm-project-overlay/llvm/BUILD.bazel
+++ utils/bazel/llvm-project-overlay/llvm/BUILD.bazel
@@ -404,6 +404,7 @@
     deps = [
         ":BinaryFormat",
         ":DebugInfoCodeView",
+        ":ProfileData",
         ":Support",
         ":config",
         ":ir_headers",
@@ -468,7 +469,6 @@
     features = ["-header_modules"],
     strip_include_prefix = "utils/TableGen",
     deps = [
-        ":MC",
         ":Support",
         ":TableGen",
         ":config",


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D107480.364169.patch
Type: text/x-patch
Size: 610 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210804/62657bdd/attachment.bin>


More information about the llvm-commits mailing list