[PATCH] D107478: [SelectionDAG] Correctly determine the VECREDUCE_SEQ_FMUL action

Fraser Cormack via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 4 09:52:01 PDT 2021


frasercrmck created this revision.
frasercrmck added reviewers: spatel, RKSimon, craig.topper, cameron.mcinally.
Herald added subscribers: ecnelises, hiraditya.
frasercrmck requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

The LegalizeAction for this node should follow the logic for
`VECREDUCE_SEQ_FADD` and be determined using the vector operand's type.

here isn't an in-tree target that makes use of this, but I think it's safe to
say this is how it should behave, should a target want to customize the action
for this node.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D107478

Files:
  llvm/lib/CodeGen/SelectionDAG/LegalizeDAG.cpp


Index: llvm/lib/CodeGen/SelectionDAG/LegalizeDAG.cpp
===================================================================
--- llvm/lib/CodeGen/SelectionDAG/LegalizeDAG.cpp
+++ llvm/lib/CodeGen/SelectionDAG/LegalizeDAG.cpp
@@ -1181,6 +1181,7 @@
         Node->getOpcode(), Node->getOperand(0).getValueType());
     break;
   case ISD::VECREDUCE_SEQ_FADD:
+  case ISD::VECREDUCE_SEQ_FMUL:
     Action = TLI.getOperationAction(
         Node->getOpcode(), Node->getOperand(1).getValueType());
     break;


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D107478.364164.patch
Type: text/x-patch
Size: 501 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210804/dc1ae57f/attachment.bin>


More information about the llvm-commits mailing list