[PATCH] D107443: AArch64: support @llvm.va_copy in GISel

[Jessica Paquette via Phabricator via llvm-commits]

paquette added inline comments.


================
Comment at: llvm/lib/Target/AArch64/GISel/AArch64LegalizerInfo.cpp:968
+
+    MachineFunction &MF = *MI.getParent()->getParent();
+    auto Val = MF.getRegInfo().createGenericVirtualRegister(
----------------
slightly more succinct


================
Comment at: llvm/lib/Target/AArch64/GISel/AArch64LegalizerInfo.cpp:975
+                                           MachineMemOperand::MOLoad,
+                                           VaListSize, Align(8)));
+    MIB.buildStore(Val, MI.getOperand(1),
----------------
SDAG sets `Align` to be the pointer size here. Should we do that too?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107443/new/

https://reviews.llvm.org/D107443