[PATCH] D107452: [AArch64] Fix assert AArch64TargetLowering::ReplaceNodeResults

[Dave Green via Phabricator via llvm-commits]

dmgreen accepted this revision.
dmgreen added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/test/CodeGen/AArch64/fptosi-strictfp.ll:10
+}
+; CHECK: bl	__fixtfti
+
----------------
simonwallis2 wrote:
> dmgreen wrote:
> > Add CHECK-LABEL, and maybe move before the test_fixtfti function? Or just use the update script.
> OK I'll add some CHECK-LABELs.
> Is there an advantage in moving before the test_fixfti function?
> I'm not sure what update script you mean.
It's just more standard - I would expect to find the check lines before the function, where you have added the CHECK-LABEL.

The update script is the llvm/utils/update_llc_test_checks.py script, which can fill in the check lines for you. In this case it won't make much difference, as it is already checking the important parts. For some tests that can change in the future it makes the tests easier to maintain.

I would move the CHECK line next to the CHECK-LABEL to keep them together. Otherwise LGTM.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107452/new/

https://reviews.llvm.org/D107452