[PATCH] D107459: [X86] Rename Subtarget Tuning Feature Flag Prefix. NFC.

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 4 07:02:23 PDT 2021


RKSimon created this revision.
RKSimon added reviewers: craig.topper, pengfei.
Herald added a subscriber: hiraditya.
RKSimon requested review of this revision.
Herald added a project: LLVM.

As suggested on D107370 <https://reviews.llvm.org/D107370>, this is a possible patch to rename the tuning feature flags to start with 'Tuning' instead of 'Feature'.

Unfortunately I'm not sure we should do this for security mitigation flags as the llvm/Support/X86TargetParser.def code uses 'llvm::X86::FEATURE_##' style stubs that include some of these flags - we're probably better off keeping the enum names as similar as possible?


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D107459

Files:
  llvm/lib/Target/X86/MCTargetDesc/X86AsmBackend.cpp
  llvm/lib/Target/X86/X86.td
  llvm/lib/Target/X86/X86MCInstLower.cpp
  llvm/lib/Target/X86/X86TargetTransformInfo.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D107459.364089.patch
Type: text/x-patch
Size: 47164 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210804/4f4dee43/attachment.bin>


More information about the llvm-commits mailing list